so this is a problem from cs50 W3 runoff, when I am running this code I am getting the following error, I cant understand why?
I don’t find any problem with the code, so need help from more experienced programmers
`I am unable to understand this error,
“:( print_winner prints name when someone has a majority
print_winner did not print winner of election
🙁 print_winner returns true when someone has a majority
print_winner did not print winner and then return true”
help me solve it,please.
the code,
#include <cs50.h>
#include <stdio.h>
#include <string.h>
#include <math.h>
// Max voters and candidates
#define MAX_VOTERS 100
#define MAX_CANDIDATES 9
// preferences[i][j] is jth preference for voter i
int preferences[MAX_VOTERS][MAX_CANDIDATES];
// Candidates have name, vote count, eliminated status
typedef struct
{
string name;
int votes;
bool eliminated;
} candidate;
// Array of candidates
candidate candidates[MAX_CANDIDATES];
// Numbers of voters and candidates
int voter_count;
int candidate_count;
// Function prototypes
bool vote(int voter, int rank, string name);
void tabulate(void);
bool print_winner(void);
int find_min(void);
bool is_tie(int min);
void eliminate(int min);
int main(int argc, string argv[])
{
// Check for invalid usage
if (argc < 2)
{
printf("Usage: runoff [candidate ...]n");
return 1;
}
// Populate array of candidates
candidate_count = argc - 1;
if (candidate_count > MAX_CANDIDATES)
{
printf("Maximum number of candidates is %in", MAX_CANDIDATES);
return 2;
}
for (int i = 0; i < candidate_count; i++)
{
candidates[i].name = argv[i + 1];
candidates[i].votes = 0;
candidates[i].eliminated = false;
}
voter_count = get_int("Number of voters: ");
if (voter_count > MAX_VOTERS)
{
printf("Maximum number of voters is %in", MAX_VOTERS);
return 3;
}
// Keep querying for votes
for (int i = 0; i < voter_count; i++)
{
// Query for each rank
for (int j = 0; j < candidate_count; j++)
{
string name = get_string("Rank %i: ", j + 1);
// Record vote, unless it's invalid
if (!vote(i, j, name))
{
printf("Invalid vote.n");
return 4;
}
}
printf("n");
}
// Keep holding runoffs until winner exists
while (true)
{
// Calculate votes given remaining candidates
tabulate();
// Check if election has been won
bool won = print_winner();
if (won)
{
break;
}
// Eliminate last-place candidates
int min = find_min();
bool tie = is_tie(min);
// If tie, everyone wins
if (tie)
{
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
printf("%sn", candidates[i].name);
}
}
break;
}
// Eliminate anyone with minimum number of votes
eliminate(min);
// Reset vote counts back to zero
for (int i = 0; i < candidate_count; i++)
{
candidates[i].votes = 0;
}
}
return 0;
}
// Record preference if vote is valid
bool vote(int voter, int rank, string name)
{
// TODO
//match the name
for(int i = 0; i < candidate_count; i++)
{
if(strcmp(candidates[i].name , name) == 0)
{
preferences[voter][rank] = i;
return true;
}
}
return false;
}
// Tabulate votes for non-eliminated candidates
void tabulate(void)
{
// TODO
for(int i = 0; i < voter_count; i++)
{
for(int j = 0; j < candidate_count; j++)
{
int candidate_index = preferences[i][j];
if(!candidates[candidate_index].eliminated)
{
candidates[candidate_index].votes++;
break;
}
}
}
return;
}
// Print the winner of the election, if there is one
bool print_winner(void)
{
// TODO
int majority = round(voter_count / 2 + 1);
for (int i = 0; i < candidate_count; i++)
{
string name = candidates[i].name;
if(candidates[i].votes >= majority)
{
printf("%s", name);
return true;
}
}
return false;
}
// Return the minimum number of votes any remaining candidate has
int find_min(void)
{
// TODO
int min_vote = MAX_VOTERS + 1;
for(int i = 0; i < candidate_count; i++)
{
if(!candidates[i].eliminated && candidates[i].votes < min_vote)
{
min_vote = candidates[i].votes;
}
}
return min_vote;
}
// Return true if the election is tied between all candidates, false otherwise
bool is_tie(int min)
{
// TODO
for(int i = 0; i < candidate_count; i++)
{
if(!candidates[i].eliminated && candidates[i].votes != min)
{
return false;
}
}
return true;
}
// Eliminate the candidate (or candidates) in last place
void eliminate(int min)
{
// TODO
for(int i = 0; i < candidate_count; i++)
{
if(candidates[i].votes == min && !candidates[i].eliminated)
{
candidates[i].eliminated = true;
}
}
return;
}
Nafis Islam is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.