Right now I’m interning at a major engineering company. I’ll be leaving in a few months though, so my project manager has requested a print out of my source code for a VBA project I’ve been working on.
He would like to have it reviewed to make sure I didn’t do anything ridiculous, and to make sure it’s organized well enough for someone to maintain easily enough once I’m gone.
I’m not really sure why he would want a print out instead of files, but since the VBA editor is ugly as sin this is probably a good thing.
I would like to make an impression with this – however minor – so my question is how can I make this look professional? I.e., maybe there are certain fonts that make sense here, perhaps I could apply a color scheme to the words, etc?
1
Use something like Notepad++ or a similar syntax highlighting application that will print out your code in colour (if you’re allowed to). Otherwise, black and white is fine – but colour with highlighting makes it easier to read. Some points to consider:
-
Ensure you have consistant spacing and formatting in your code, and your code is as readable as you can possibly make it.
-
Make sure any code that spans over one line prints nicely, you may need to mess about a bit.
-
Use a monospaced font – it will improve readability by miles. Once again, most “advanced” notepad-like applications will do this for you by default.
-
Print with line numbers, as in a paper-based code review many people will refer to a line number rather than a statement when making comment.
-
Put a header and/or footer that contains the file/module name and page number. Even with line numbers printed, it’s nice to have page numbers to give your readers an easy way to sort pages out in the event they get mixed up.
If you understood him correctly
He would like to have it reviewed to make sure I didn’t do anything
ridiculous, and to make sure it’s organized well enough for someone to
maintain easily enough once I’m gone.
then that is your goal, not aesthetics or to please him because it makes you feel better.
When I write code that is for use for others, I write it for others with good comments, meaningful variable names, following the standard formatting conventions of the language or the group and move on.
If you didn’t try and sabotage the company with malicious code then you probably pass the first requirement. If you have confidence in your code and good comments then what more do you need to meet his requirements. Print it out, hand it over and move on.
“… a print out of my source code …” – Don’t bother. He probably won’t even read it. I’ve had managers like that in the past – a long way in the past … in old government departments … who had no idea what programming was about – even then.
If you really want to do this, just dump your code and forget it. I suspect he’s either deliberately messing with you or is totally 404. In either case, impressing him will not benefit you in any way and a request like that would be enough for me to put that company on my “Never want to work there list”.
8